CLDR-17192 kbd: Separate PR for marker pseudocode #3470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- split from PR unicode-org#3445
jahorton
reviewed
Jan 30, 2024
| } | ||
|
|
||
| // now, process input codepoints from end to beginning | ||
| for (i=input.end;i>=input.begin;i--) { |
There was a problem hiding this comment.
Since this code's been spun off, here's a link to my old comment re: this section - #3445 (comment)
1 task
jahorton
reviewed
Jan 30, 2024
Comment on lines
+2923
to
+2924
| - `nfdMarkers('e\u{0300}' + Marker('marker1') + '\u{0320}a\u{0300}' + Marker('marker2') + '\u{0320}')` | ||
| - Returns: `'e' + Marker('marker1') + '\u{0320}\u{0300}a' + Marker('marker2') + '\u{0320}\u{0300}'` |
There was a problem hiding this comment.
Reminder of a point from the original PR: #3445 (comment)
Since you use
'\u{0300}'and'\u{0320}'following both the'e'and the'a', it's easy to confuse what's happening in the center part.I agree with the comment. Don't use duplicate characters in the example when the positions may change.
|
moot, folded into #3445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17192
ALLOW_MANY_COMMITS=true